[Instructions -0.13% vs main; paired PGO estimate] Check trivial MIR sizedness before interning an obligation - #133
Draft
xmakro wants to merge 1 commit into
Draft
Conversation
xmakro
changed the title
xmakro
force-pushed
the
perf-review-20260907/19-resolved-value-fold
branch
from
September 9, 2026 06:21
5a46fc2 to
667a2c9
Compare
xmakro
force-pushed
the
perf-review-20260907/20-borrowck-sized-before-intern
branch
from
September 9, 2026 06:21
c435c81 to
25abaad
Compare
xmakro
changed the title
xmakro
changed the base branch from
perf-review-20260907/19-resolved-value-fold
to
main
September 9, 2026 06:21
xmakro
force-pushed
the
perf-review-20260907/20-borrowck-sized-before-intern
branch
from
September 13, 2026 04:01
25abaad to
765476f
Compare
xmakro
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Apply the existing trivial Sized reasoning before creating the MIR assignment trait reference and predicate. Preserve the lang-item requirement, solver mode, snapshot and pending-region guards.
Negative percentages mean less elapsed time or fewer resources. The title is an individual local instruction-count estimate: instructions:u as an equal-case geometric mean over the 249 Primary cases, the metric the upstream perf bot summarizes; small changes may be measurement noise.
The two recorded repetitions give aggregate instruction estimates of -0.126% and -0.127% for the title comparison. Mixed directions are marked in the title. This repeatability check is not a confidence interval.
Both compilers use the same source base, CI LLVM, fixed standard libraries, ThinLTO and jemalloc. Each has separate nine-workload Rust PGO training. The stock collector measures all 20 Primary benchmarks: 249 Check/Debug/Opt and full/incremental cases, two observations per compiler per case, alternating baseline/candidate order by crate. No other campaign builds run during measurement. Percentages are equal-case geometric means. LLVM retraining and BOLT are omitted.
This branch has one commit directly on main. Its exact measured source passed the full UI and incremental suites plus the additional suites recorded in the build provenance.
Required support copied without the other optimizations: has_pending_region_state accessor from PR 115; no type-op early return.
Fixed main commit:
da47efd27287edb02eed0b5a178a165c8f258e37. Measured source patch SHA-256:fb31639d2a9d5a0d44f9d42a1f933a678821b72b2004e30fdf4ddc2db6077fbd.Local raw measurements and per-case CSVs:
independent-pr133-main-v1-comparison.csvin the September 6 investigation directory. Build/test provenance:pgo/independent-pr133-source-timing-v1/provenance.json.