Conversation
There was a problem hiding this comment.
Pull request overview
Adds initial vx4b enablement across build, CI, and examples by updating dependencies and adjusting architecture-specific build/parallelization behavior.
Changes:
- Update build integration to use
ai_tools(CMake subproject/target) and bumpxmos-ai-tools/py_voicetest dependencies. - Add
vx4b-specific handling in VNR model export (xcore-opttarget arch + threshold) and AEC parallel compilation guards. - Convert
app_pipelineexample from multi-tile to single-tile multi-thread (channel +PAR_JOBS) and adjust metadata layout.
Reviewed changes
Copilot reviewed 22 out of 23 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/stage_b/CMakeLists.txt | Add ai_tools and normalize sandbox dependency inclusion. |
| tests/requirements_test.txt | Bump Python test dependencies (xmos-ai-tools, py_voice). |
| tests/profile_memory/lib_voice_memory.json | Update recorded memory numbers. |
| tests/profile_memory/lib_voice_memory_table.rst | Update memory table value for VNR. |
| tests/lib_vnr/test_vnr_cffi/CMakeLists.txt | Add ai_tools to dependency subdirectories. |
| tests/lib_ic/py_c_frame_compare/CMakeLists.txt | Add ai_tools to dependency subdirectories. |
| tests/custom_cmake_build/CMakeLists.txt | Add ai_tools to dependency subdirectories. |
| requirements.txt | Bump xmos-ai-tools version. |
| lib_voice/vnr_model.cmake | Add vx4b arch handling for model export and set xcore-opt target arch. |
| lib_voice/src/vnr/vnr.c | Simplify init error handling (now assert-based). |
| lib_voice/src/aec/aec_process_frame.c | Enable parallel header/paths for __VX4B__. |
| lib_voice/lib_build_info.cmake | Update dependent modules, add arch-specific warning suppressions, adjust linking expectations. |
| lib_voice/CMakeLists.txt | Link VNR module against ai_tools instead of tflite_micro. |
| Jenkinsfile | Update shared library and add CI build path for vx4b tools/build. |
| examples/app_vnr/CMakeLists.txt | Allow external override of APP_HW_TARGET. |
| examples/app_pipeline/src/pipeline.c | Rename tile→thread APIs and adjust metadata usage. |
| examples/app_pipeline/src/pipeline_state.h | Change metadata type and rename state structs (tile→thread). |
| examples/app_pipeline/src/main.xc | Remove multi-tile XC main. |
| examples/app_pipeline/src/app.c | Add single-tile threaded main using channels + PAR_JOBS. |
| examples/app_pipeline/CMakeLists.txt | Allow external override of APP_HW_TARGET. |
| examples/app_aec/CMakeLists.txt | Allow external override of APP_HW_TARGET. |
| doc/rst/examples/index.rst | Update literalinclude snippet to match metadata API change. |
| CHANGELOG.rst | Add UNRELEASED entry for vx4b support + related changes. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
10
to
12
| int32_t ret = vnr_inference_init(); | ||
| if(ret) { | ||
| printf("vnr_inference_init() returned error %ld\n",ret); | ||
| assert(0); | ||
| } | ||
| assert(ret == 0 && "vnr inference initialisation has failed"); | ||
| } |
Comment on lines
+62
to
+63
| // Send data to process to the other thread and receive processed output back | ||
| // Send the "valid" signal first |
xalbertoisorna
approved these changes
Jun 1, 2026
xalbertoisorna
left a comment
Contributor
There was a problem hiding this comment.
looks good!
the assert point is out of scope but good to note somewhere.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.