Fix compiler warnings#51
Open
Allan-xmos wants to merge 1 commit into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
This PR performs small type/signature cleanups to better align channel-indexing and IC frame APIs with the existing internal representations and constants.
Changes:
- Use an unsigned loop index when iterating over
num_y_channelsinstage1_process_frame(). - Update
ic_frame_init()’s input buffer annotations to useIC_FRAME_ADVANCE(matching how the function consumes the buffers).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| lib_voice/src/stage1/stage1.c | Aligns the per-channel loop index type with the unsigned channel count used by AEC shared state. |
| lib_voice/src/ic/ic_low_level.h | Makes the ic_frame_init() prototype reflect that it consumes IC_FRAME_ADVANCE new samples per frame. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
uvvpavel
approved these changes
Jul 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.