Skip to content

BLD: download_models.py respect HTTP Error 429#155

Merged
codingl2k1 merged 4 commits into
mainfrom
bld/enhance_download_model
Jun 7, 2026
Merged

BLD: download_models.py respect HTTP Error 429#155
codingl2k1 merged 4 commits into
mainfrom
bld/enhance_download_model

Conversation

@codingl2k1

Copy link
Copy Markdown

No description provided.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces robust HTTP 429 rate-limit handling and retry logic with exponential backoff to the model downloading script, while also reducing parallel connection limits to prevent rate limiting. The review feedback points out a potential issue with clock drift when parsing the 'Retry-After' header and suggests calculating the delay relative to the server's 'Date' header instead of the local system time.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread scripts/download_models.py
@codingl2k1 codingl2k1 merged commit 615f177 into main Jun 7, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant