BLD: Refine cuda build#156
Merged
Merged
Conversation
Removed the detect_cuda_architectures function and updated CUDA architecture handling to default to 'all' if not set in the environment.
Updated delvewheel repair command to include CUDA path adjustments for Windows.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request simplifies the build script by removing the custom detect_cuda_architectures function and defaulting to CMake's "all" keyword when CUDA_ARCHITECTURES is not set. The reviewer suggests using "native" instead of "all" as a fallback for local builds to avoid excessively long compilation times and resource usage by targeting only the host's GPU architecture.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Update fallback behavior for CUDA architectures in build script.
Updated CUDA requirements for Linux and Windows, added CUDA GPU architecture coverage section with details on supported architectures and compatibility.
Enhanced error handling for network issues during file downloads.
|
Great idea 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #125 #118