Repository navigation
fix(deps): adopt the rewritten logger via forge v1.11.0 - #108
Closed
juicycleff wants to merge 1 commit into
Closed
juicycleff wants to merge 1 commit into
juicycleff wants to merge 1 commit into
Conversation
Moves to forge v1.11.0 and go-utils v1.3.0. authsome was blocked on this and
not by its own code: it pulled a published forge whose internal/logger
referenced symbols go-utils v1.3.0 removed, so bumping go-utils alone failed
with
forge@v1.9.11/internal/logger/exports.go: undefined: log.FormatConfig
forge v1.11.0 carries the rewritten internal/logger, so both move together.
No API changes were needed. authsome uses almost none of the surface that
changed, and its single NewBeautifulLogger call still works through a
deprecated shim. That call now reads log.New(log.Config{Name: "authsome"}),
since an example is the wrong place to demonstrate a deprecated constructor.
What changes at runtime: log output picks its own format. A terminal gets
aligned coloured columns, anything else gets JSON, FORGE_LOG_FORMAT overrides
both, and a go test binary stays quiet unless -v is passed.
Typed fix rather than chore so the bump actually releases.
98 packages build and test clean.
Contributor
Author
|
Closing as stale. Its base predates four commits that have since landed, so
Concretely, it would undo #109's work, for example putting back and dropping The version bumps this PR carried are already on |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves authsome to forge v1.11.0 and go-utils v1.3.0.
authsome was the last repository blocked on the go-utils logger rewrite, and
not by its own code. It pulls forge from the proxy, and the published
forge@v1.9.11'sinternal/loggerreferences symbols v1.3.0 removed, sobumping go-utils alone failed:
forge v1.11.0 carries the rewritten
internal/logger, so both move together.No API changes were needed
authsome uses almost none of the surface that changed. Its single
NewBeautifulLoggercall still works through a deprecated shim; it now readslog.New(log.Config{Name: "authsome"}), because an example is the wrong placeto demonstrate a deprecated constructor.
What changes at runtime
Log output picks its own format: a terminal gets aligned coloured columns,
anything else gets JSON,
FORGE_LOG_FORMAToverrides both, and ago testbinary stays quiet unless
-vis passed.Three files:
go.mod,go.sum, and the one example line. 98 packages buildand test clean.
Titled
fix(deps)rather thanchoredeliberately, so the bump actuallyreleases. A
choresubject would land it and leave consumers resolving the oldforge.