Repository navigation
feat(setup): say when the new owner still has to verify - #126
Merged
Merged
Conversation
Setup no longer makes its account platform-owner on the spot. Ownership is claimed when the email is verified, so the operator who just finished setup lands in a dashboard they can't administer yet. SetupResponse now carries verification_required, true while the account's email is unverified, so the dashboard can say why and point them at the verification step.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#120 merged one commit short. Its first-run setup follows the verify-first rule from #124: the account setup creates becomes platform-owner when its email is verified, not at sign-up. That leaves the operator who just finished setup in a dashboard they can't administer, with nothing telling them why.
SetupResponsegainsverification_required, true while the account's email is unverified. The setup test checks it next to the existing assertions that setup alone doesn't grant ownership and verifying does.You'll want the dashboard's setup screen to read the field and point the operator at the verification step. That lives in forge-dashboard and isn't part of this PR.