Repository navigation
chore: stop wiring the Go-rendered dashboard into the extension - #39
Merged
Merged
Conversation
Forge main has removed the dashboard contributor package and DashboardAware, so the extension no longer registers its templ dashboard. The dashboard/ directory stays until its React migration retires it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Weave can't move to forge v1.12.0 until this lands. That release no longer ships
extensions/dashboard/contributororDashboardAware, andextension/extension.gostill imports both to register the templ dashboard. This drops that wiring and nothing else: theDashboardContributor()method goes, along with the compile-timeDashboardAwareassertion and four imports.The
dashboard/directory stays for now. Its replacement is the React plugin we're building in forge-dashboard, and that work deletesdashboard/in a commit of its own once the new pages have been checked in a browser.The commit is dated 2026-10-01. We stripped the same wiring from twelve extensions in one pass that day, and this checkout happened to be on
core-module-split. That branch had already merged as #26, so the commit sat on a dead branch until now. It's cherry-picked here onto a fresh branch offmain, diff unchanged.Checked on this branch:
go build ./...passesgo test ./...passesgolangci-lint run ./...with a fresh cache: 0 issuesNone of the open dependabot PRs touch
extension/extension.go. #38 bumps templ ingo.modand won't conflict, though that bump stops mattering oncedashboard/is gone.