Homework 1#10
Open
loreliawand wants to merge 3 commits intoxzfantom:mainfrom
Open
Conversation
xzfantom
reviewed
Jul 28, 2022
Owner
xzfantom
left a comment
xzfantom
left a comment
There was a problem hiding this comment.
Пара замечаний, а так вроде хорошо
|
|
||
| mySubmit = (event) => { | ||
| event.preventDefault(); | ||
| let result = {}; |
Owner
There was a problem hiding this comment.
Для копирования объекта проще использовать spread: let result = {...this.state}
| import FormHeader from './components/FormHeader'; | ||
| import InputField from './components/InputField'; | ||
| import TextAreaField from './components/TextAreaField'; | ||
| import './App.css'; |
Owner
There was a problem hiding this comment.
По условию были указаны css модули
Author
There was a problem hiding this comment.
Добавлены модули и удалён общий файл css
poulkud
reviewed
Jul 31, 2022
| }; | ||
| } | ||
|
|
||
| genHandler = (fieldName) => { |
poulkud
approved these changes
Jul 31, 2022
Collaborator
poulkud
left a comment
poulkud
left a comment
There was a problem hiding this comment.
исправить комменты. Апрув
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Исправлены замечания, которые были на ревью