Hw 6-7 Natalia Bezhenar#54
Open
NataliaBezhenar wants to merge 3 commits intoxzfantom:mainfrom
Open
Conversation
poulkud
reviewed
Aug 14, 2022
|
|
||
| const App: React.FC = () => ( | ||
| <> | ||
| <Navigation /> |
Collaborator
There was a problem hiding this comment.
такая вложенность излишняя
poulkud
reviewed
Aug 14, 2022
| @@ -0,0 +1,7 @@ | |||
| .buttongroup { | |||
poulkud
reviewed
Aug 14, 2022
| <Button onClick={toggle} aria-label="Add todo"> | ||
| Add todo | ||
| </Button> | ||
|
|
poulkud
reviewed
Aug 14, 2022
| const [isShowing, setIsShowing] = useState<boolean>(false); | ||
|
|
||
| function toggle() { | ||
| setIsShowing(!isShowing); |
Collaborator
There was a problem hiding this comment.
как пример хука гуд, но в нем нет никакого смысла потому что он не переиспользуется и никакой сложной функции нету.
poulkud
reviewed
Aug 14, 2022
|
|
||
| const routeChange = () => { | ||
| let path = "/"; | ||
| history.push(path); |
Collaborator
There was a problem hiding this comment.
тут нету смысла выносить в переменную
poulkud
approved these changes
Aug 14, 2022
Collaborator
poulkud
left a comment
poulkud
left a comment
There was a problem hiding this comment.
апрув, но поправить комменты
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
deploy: https://todolist-8a1e57-tsc.netlify.app/