Skip to content

Added qmake project include file#5

Open
richelbilderbeek wants to merge 6 commits into
yageek:masterfrom
richelbilderbeek:master
Open

Added qmake project include file#5
richelbilderbeek wants to merge 6 commits into
yageek:masterfrom
richelbilderbeek:master

Conversation

@richelbilderbeek

Copy link
Copy Markdown
Contributor

Simple file I use to pack all Meschach files in a qmake project. It is unimportant to cmake users, but I'd like to rely on this file being present for the EDIBLE GitHub.

@richelbilderbeek

Copy link
Copy Markdown
Contributor Author

P.S. I could understand you'd not want to add this: it would not fit your project description :-)

@yageek

yageek commented May 16, 2017

Copy link
Copy Markdown
Owner

Why are some files commented ?

@richelbilderbeek

Copy link
Copy Markdown
Contributor Author

Great question! I commented the files used in applications; those that have a main function. This .pri file contains the library part of Meschach only. Sure I can remove those commented lines, I can do now if you'd prefer to.

@yageek

yageek commented May 16, 2017

Copy link
Copy Markdown
Owner

May be adding a comment telling which files are removed and why would be nice :)

@richelbilderbeek

Copy link
Copy Markdown
Contributor Author

Great idea, will do and will reply here when done (the modifications will be added to the Pull Request)

@richelbilderbeek

Copy link
Copy Markdown
Contributor Author

Done :-)

@richelbilderbeek

Copy link
Copy Markdown
Contributor Author

My compiler has spotted a copy-paste error.

@richelbilderbeek

Copy link
Copy Markdown
Contributor Author

My compiler has spotted some unused local variables. I removed them.

@richelbilderbeek

Copy link
Copy Markdown
Contributor Author

@yageek: what do you think about this Pull Request?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants