Integrate basic authentication#188
Open
radutanasa wants to merge 2 commits intoyahoo:masterfrom
radutanasa:#141-BasicAuthenticationSupport
Open
Integrate basic authentication#188radutanasa wants to merge 2 commits intoyahoo:masterfrom radutanasa:#141-BasicAuthenticationSupport
radutanasa wants to merge 2 commits intoyahoo:masterfrom
radutanasa:#141-BasicAuthenticationSupport
Conversation
added 2 commits
January 18, 2016 14:46
| private[this] lazy val assetsC = new controllers.Assets(httpErrorHandler) | ||
| private[this] lazy val webJarsAssetsC = new controllers.WebJarAssets(httpErrorHandler, context.initialConfiguration, context.environment) | ||
|
|
||
| override lazy val httpFilters = Seq(BasicAuthenticationFilter(context.initialConfiguration)) |
Collaborator
There was a problem hiding this comment.
Would be great if you can add configuration to enable it. Not everyone may want to enable it.
Author
|
OK, sounds good. I'll look into it. |
|
hi, how is this merge pr going? it's nice to have authentication :) |
Author
|
There's been a request to make this configurable, but haven't had the time On Tue, Feb 23, 2016 at 4:29 AM, Fucong.Luo notifications@github.com
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Used play-basic-authentication-filter from kaliber