Юнит-тесты для Burger с 100% покрытием#1297
Open
yellowDucklingVi wants to merge 4 commits intoyandex-praktikum:mainfrom
Open
Юнит-тесты для Burger с 100% покрытием#1297yellowDucklingVi wants to merge 4 commits intoyandex-praktikum:mainfrom
yellowDucklingVi wants to merge 4 commits intoyandex-praktikum:mainfrom
Conversation
yellowDucklingVi
commented
Apr 4, 2026
yellowDucklingVi
commented
- Подключены JUnit 4, Mockito, JaCoCo.
- Класс Burger покрыт тестами на 100% (отчёт в папке jacoco-report).
- Использованы моки, стабы и параметризация.
okryukova
reviewed
Apr 5, 2026
| Bun bunMock = mock(Bun.class); | ||
| when(bunMock.getPrice()).thenReturn(100f); | ||
|
|
||
| Ingredient i1 = mock(Ingredient.class); |
There was a problem hiding this comment.
⛔️Нужно исправить. При нейминге не рекомендуется использовать числа (Field2), их еще называют magicNumbers. Очень тяжело поддерживать код с magicNumbers.
okryukova
reviewed
Apr 9, 2026
| public class BurgerPriceParameterizedTest { | ||
|
|
||
| private static final float BUN_PRICE = 100f; | ||
| private static final float INGREDIENT_PRICE_1 = 50f; |
There was a problem hiding this comment.
⛔️Нужно исправить. При нейминге не рекомендуется использовать числа (Field2), их еще называют magicNumbers. Очень тяжело поддерживать код с magicNumbers.
okryukova
approved these changes
Apr 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.