Add BurgerTest with 100% coverage#1302
Open
DanilaNigmatullin wants to merge 3 commits intoyandex-praktikum:mainfrom
Open
Add BurgerTest with 100% coverage#1302DanilaNigmatullin wants to merge 3 commits intoyandex-praktikum:mainfrom
DanilaNigmatullin wants to merge 3 commits intoyandex-praktikum:mainfrom
Conversation
okryukova
reviewed
Apr 14, 2026
| @Test | ||
| public void addIngredientAddsOneIngredient() { | ||
| burger.addIngredient(mockSauce); | ||
| assertEquals(1, burger.ingredients.size()); |
There was a problem hiding this comment.
⛔️Нужно исправить. Для юнит-тестов придерживаемся подхода: один тест, значит одна проверка. Если очень хочется несколько проверок -- тогда используем softAssertions. Поправь, пожалуйста, во всем коде
| String receipt = burger.getReceipt(); | ||
| assertTrue(receipt.contains("Булочка")); | ||
| } | ||
|
|
There was a problem hiding this comment.
⛔️Нужно исправить. Нужен хотя бы один параметризированный тест
There was a problem hiding this comment.
⛔️Нужно исправить. Файл нужно добавить в .gitignore
okryukova
reviewed
Apr 14, 2026
| String receipt = burger.getReceipt(); | ||
| assertTrue(receipt.contains("cutlet")); | ||
| } | ||
| } No newline at end of file |
There was a problem hiding this comment.
⛔️Нужно исправить. Необходимо приложить jacoco отчет в пулл реквест
okryukova
approved these changes
Apr 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Подключены JUnit 4, Mockito, JaCoCo. Написаны тесты для класса Burger, покрытие 100%