Open
Conversation
YakushevVladimir
commented
Oct 21, 2017
YakushevVladimir
commented
- Обновление версии Gradle, Android Build Tools, настройка сборки с учетом изменений
- Версия targetSDK поднята до 26
- Исправлены варнинги для TextUtilsExt.join() в Table и ShareUtils
- Добавлены в манифест разрешения для записи аудио и запрос разрешений при старте распознавания
- gradle 2.4 -> 3.3 - gradle tools 1.3.0 -> 2.3.3 - Android SDK 23 -> 26 - Android Build Tools 21.1.2 -> 26.0.1 - remove aarLinkSources plugin (This plugin in deprecated. AndroidStudio 1.4 has this support built in. https://github.com/xujiaao/AARLinkSources) - exclude support library version number to root project
…Index() and add unit-test ShareUtils.prepareMailToIntent(),
> ShareUtils.java:52: warning: non-varargs call of varargs method with inexact argument type for last parameter;
> TextUtilsExt.join(",", (String[]) addresses),
> ^
> cast to Object for a varargs call
> cast to Object[] for a non-varargs call and to suppress this warning
> /Users/ru_phoenix/Projects/yandex/deaf/app/src/main/java/ru/yandex/subtitles/content/provider/database/Table.java:89: warning: non-varargs call of varargs method with inexact argument type for last parameter;
> "(" + TextUtilsExt.join(", ", onColumns) + ");";
> ^
> cast to Object for a varargs call
> cast to Object[] for a non-varargs call and to suppress this warning
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.