Adapt to PPI 1.286 (check for defined code before passing to PPI::Doc…#12
Open
jplesnik wants to merge 1 commit into
Open
Adapt to PPI 1.286 (check for defined code before passing to PPI::Doc…#12jplesnik wants to merge 1 commit into
jplesnik wants to merge 1 commit into
Conversation
…ument->new) PPI 1.286 refactored PPI::Lexer::lex_source() for a performance fix (GH#318). The old version explicitly rejected undef input with "unless ( defined $source and not ref $source )". The new version removed this check, so PPI::Document->new(\undef) now returns a valid empty PPI::Document instead of failing. This caused PPIx::EditorTools::process_doc() to silently succeed when called without valid ppi or code arguments, because PPI::Document->new(\$code) with undef $code now creates a valid empty document. Fix by guarding the PPI::Document->new() call with a defined check on $code, and by dropping the @subs argument from use_ok() since the module doesn't export anything. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ument->new)
PPI 1.286 refactored PPI::Lexer::lex_source() for a performance fix (GH#318). The old version explicitly rejected undef input with "unless ( defined $source and not ref $source )". The new version removed this check, so PPI::Document->new(\undef) now returns a valid empty PPI::Document instead of failing.
This caused PPIx::EditorTools::process_doc() to silently succeed when called without valid ppi or code arguments, because PPI::Document->new($code) with undef $code now creates a valid empty document.
Fix by guarding the PPI::Document->new() call with a defined check on $code, and by dropping the @subs argument from use_ok() since the module doesn't export anything.