Skip to content

fix: resolve remaining code scanning alerts#3

Merged
yaniv-golan merged 1 commit intomainfrom
fix/security-scanning-alerts
Apr 25, 2026
Merged

fix: resolve remaining code scanning alerts#3
yaniv-golan merged 1 commit intomainfrom
fix/security-scanning-alerts

Conversation

@yaniv-golan
Copy link
Copy Markdown
Owner

Summary

  • Pin all GitHub Actions in codeql.yml and scorecard.yml to commit SHAs (closes PinnedDependenciesID alerts #14–#16, #25–#28)
  • Scope security-events: write to the analyze job in codeql.yml (closes TokenPermissionsID #29)
  • Scope contents: write and id-token: write to per-job permissions in release.yml (closes TokenPermissionsID #30)
  • Add explanatory comment to empty except ImportError: pass in images.py (closes py/empty-except #42)
  • Replace "flickr.com" in url substring checks with is_flickr_url() in test_pages.py and test_social.py (closes py/incomplete-url-substring-sanitization #35, #37)

Alerts #31–#34 (Scorecard process metrics) and #38 (autoescape=False in unit test) were dismissed via the GitHub API with appropriate reasons.

Test plan

  • CI passes (ruff, mypy, pytest)
  • CodeQL scan on this PR shows no new alerts
  • Scorecard workflow runs without errors on merge

🤖 Generated with Claude Code

- Pin all GitHub Actions in codeql.yml and scorecard.yml to commit SHAs
- Scope security-events:write to the analyze job in codeql.yml
- Scope contents:write and id-token:write to per-job in release.yml
- Add explanatory comment to empty ImportError except in images.py
- Replace flickr.com substring URL checks with is_flickr_url() in
  test_pages.py and test_social.py

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 25, 2026

Welcome to Codecov 🎉

Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.

ℹ️ You can also turn on project coverage checks and project coverage reporting on Pull Request comment

Thanks for integrating Codecov - We've got you covered ☂️

@yaniv-golan yaniv-golan merged commit 2417ab8 into main Apr 25, 2026
13 checks passed
@yaniv-golan yaniv-golan deleted the fix/security-scanning-alerts branch April 25, 2026 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant