Skip to content

Fixed newline problem in Show All Defined Sequences.py #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
justinpenner wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fixed newline problem in Show All Defined Sequences.py #4

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3790ef9
Newlines fixed
justinpenner Jan 5, 2024
bcb0f3c
Update README.md
justinpenner Jan 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion Contextual Kerning/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,6 @@ You can also load all stored sequences with ___Show All Defined Sequences___ and

* I couldn’t find a way yet to programmatically delete a _Token_ from a font master. I need to ask Georg how to do that. Until that's possible, "deleting" a sequence will actually set all values to 0. This is dumb because it will still end up in your feature code like that, just not have any effect. Looking for a solution to this.
* There is currently no support for exceptions to contextual kerning and I'm not sure how to go about this.
* When showing all defined sequences, I wanted to show the one line at a time, but adding `GSControlCharacter` items to the tab results in an error in Glyphs. Again, I need to consult with Georg for that. Until then, the sequences are simply separated by a word space.
* It’s kind of dumb to expand kerning classes into enumerated sequences (`[a b c ...]`) in the feature code, but this was the only way I could make this work for both *Glyphs* as well as *glyphsLib*. In the end it doesn’t matter, as kerning classes don’t exist in OpenType fonts anyway. What exists as classes in the source file ends up enumerated in the font in the end for each lookup. Just make sure that you update the feature code whenever you change kerning class members.

## Example
Expand Down
7 changes: 4 additions & 3 deletions Contextual Kerning/Show All Defined Sequences.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@

class_match = re.compile(r"(@[a-zA-Z0-9_.-]+)")

NEWLINE = font.glyphs["space"].layers[font.selectedFontMaster.id]
NEWLINE = GSControlLayer(10)


def first_glyph_in_class(class_name, direction):
Expand Down Expand Up @@ -56,8 +56,9 @@ def first_glyph_in_class(class_name, direction):
glyphs = [font.glyphs[name] for name in sequence.split(" ")]
lines.extend([glyph.layers[font.selectedFontMaster.id] for glyph in glyphs] + [NEWLINE])

font.newTab(lines)
tab = font.tabs[-1]
tab = font.newTab()
tab.layers = lines

if direction == "RTL":
tab.direction = GSRTL
else:
Expand Down