feat: add dialog component #22
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laravdiemen
requested review from
FreakyWizard,
JasperS20,
Rovasch,
SimonvanWijhe,
WybeBosch,
Yannicvanveen,
YvetteNikolov,
dtakken,
hnccox-yard,
ictbeheer,
mvdhoek1 and
rivanuff
| <button | ||
| {{ $attributes->merge([ | ||
| 'data-dialog-id' => $dialogId, | ||
| 'type' => 'button', |
Contributor
There was a problem hiding this comment.
Slim, voor als het in een <form> staat zeker
YvetteNikolov
approved these changes
Jan 28, 2026
Contributor
YvetteNikolov
left a comment
YvetteNikolov
left a comment
There was a problem hiding this comment.
Kun je de Readme uitbreiden met een voorbeeld (zo'n simpele modal?)
laravdiemen
force-pushed
the
feat/dialog-component
branch
from
a181ca6 to
646f297
Compare
WybeBosch
approved these changes
Jan 28, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Een algemeen dialog component dat samenwerkt met de algemene javascript in de brave-frontend-kit.
Gerelateerde PR brave-frontend-kit: yardinternet/brave-frontend-kit#21
Gerelateerde PR brave: yardinternet/brave#28