(feat): add vite alias from acorn 5.0 #11
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YvetteNikolov
requested review from
a team,
Rovasch,
SimonvanWijhe,
dtakken,
hnccox-yard,
ictbeheer,
mvdhoek1 and
robertbossaert
and removed request for
a team
Member
|
En als we Acorn in brave updaten naar 5.0 is deze fix hier dan nog nodig? |
Contributor
|
@SimonvanWijhe nee die fix zit al in Acorn 5; dus deze package moet een v2 krijgen die compatible met Acorn 5 ondersteunt. |
mvdhoek1
approved these changes
Apr 15, 2025
ictbeheer
reviewed
Apr 15, 2025
src/helpers.php
Outdated
| \Yard\SageChildThemeSupport\Console\Kernel::class | ||
| ); | ||
|
|
||
| $bootloader->getApplication()->alias(Vite::class, FoundationVite::class); |
Contributor
There was a problem hiding this comment.
Kan je hier nog de FQCN gebruiken, net als bij de twee bindings? Dan is het wat duidelijker wat er precies ge-aliast wordt.
Contributor
Author
There was a problem hiding this comment.
Kan je hier nog de FQCN gebruiken, net als bij de twee bindings? Dan is het wat duidelijker wat er precies ge-aliast wordt.
Done
SimonvanWijhe
approved these changes
Apr 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dit is nodig om de asset enqueueing van Vite werkend te maken (wanneer de assets gebuild zijn voor productie). Samen met Maarten afgekeken van hoe Acorn 5.0 dit doet:
Maarten zegt wel dat we deze package op een gegeven moment moeten hernoemen :-)