Skip to content

Conversation

@ictbeheer
Copy link
Contributor

No description provided.

@github-actions
Copy link

Composer package changes
Prod Packages Operation Base Target
guzzlehttp/guzzle New - 7.9.2
guzzlehttp/promises New - 2.0.4
guzzlehttp/psr7 New - 2.7.0
psr/http-client New - 1.0.3
psr/http-factory New - 1.1.0
psr/http-message New - 2.0
ralouphie/getallheaders New - 3.0.3
roots/acorn New - v4.3.1
roots/support New - v1.0.1
spatie/laravel-package-tools Removed 1.16.6 -

Copy link
Member

@SimonvanWijhe SimonvanWijhe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Zou dit ook werken in een Sage+Acorn theme dat niet Brave is? In dat geval kunnen we het beter yard/sage-child noemen

@SimonvanWijhe
Copy link
Member

In de nieuwe versie van Acorn gebruiken ze trouwens \Illuminate\Foundation\Bootstrap\LoadConfiguration::class, ipv \Roots\Acorn\Bootstrap\LoadConfiguration::class dus daar moeten we tzt even naar kijken.

https://github.com/roots/acorn/blob/a6c14b2d1603fe74283d0f5189c87b3cd39c7e0f/src/Roots/Acorn/Http/Kernel.php

@SimonvanWijhe
Copy link
Member

SimonvanWijhe commented Nov 26, 2024

Ah en dit is straks ook opgelost roots/acorn#375

Copy link
Member

@SimonvanWijhe SimonvanWijhe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ik zou phpstan en test workflows er maar uit halen.

En hernoemen..

Misschien: yard/sage-child-theme-support

Copy link

@mvdhoek1 mvdhoek1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PHPStan heeft nog wel een paar opmerkingen, verder uitstekend!

@ictbeheer ictbeheer merged commit 95f21cd into main Dec 4, 2024
@ictbeheer ictbeheer deleted the feat/initial branch December 4, 2024 13:52
@ictbeheer ictbeheer mentioned this pull request Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants