-
Notifications
You must be signed in to change notification settings - Fork 0
(feat) initial version #2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Composer package changes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Zou dit ook werken in een Sage+Acorn theme dat niet Brave is? In dat geval kunnen we het beter yard/sage-child noemen
|
In de nieuwe versie van Acorn gebruiken ze trouwens \Illuminate\Foundation\Bootstrap\LoadConfiguration::class, ipv \Roots\Acorn\Bootstrap\LoadConfiguration::class dus daar moeten we tzt even naar kijken. |
|
Ah en dit is straks ook opgelost roots/acorn#375 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ik zou phpstan en test workflows er maar uit halen.
En hernoemen..
Misschien: yard/sage-child-theme-support
mvdhoek1
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PHPStan heeft nog wel een paar opmerkingen, verder uitstekend!
No description provided.