Thread custom process groups through MoE grad finalization#19
Open
yashaswikarnati wants to merge 4 commits into
Open
Thread custom process groups through MoE grad finalization#19yashaswikarnati wants to merge 4 commits into
yashaswikarnati wants to merge 4 commits into
Conversation
yashaswikarnati
commented
May 13, 2026
| # TODO(Hepteract): delete the usage of the global parallel_state. | ||
| group=parallel_state.get_tensor_and_data_parallel_group(with_context_parallel=True), | ||
| ) | ||
| tp_dp_cp_group = parallel_state.get_tensor_and_data_parallel_group( |
Owner
Author
There was a problem hiding this comment.
we can remove TODO on 1183 ?
yashaswikarnati
commented
May 13, 2026
| from tests.unit_tests.test_utilities import Utils | ||
|
|
||
|
|
||
| _MISSING = object() |
Owner
Author
There was a problem hiding this comment.
i dont like fake tests with monkey patches.. ci actually runs the test on 8 gpus.. is there a way of less verbose and actua testing
Owner
Author
There was a problem hiding this comment.
Addressed in 53f2fa5. Removed the monkeypatch-based finalize tests and replaced them with real distributed coverage: the tests initialize model parallel, build actual ProcessGroupCollection values, run finalize_model_grads, and verify router expert-bias update / early validation behavior. Verified on an 8-GPU cog job: 11732530.
yashaswikarnati
commented
May 13, 2026
| os.environ.pop('NVTE_FLASH_ATTN', None) | ||
| os.environ.pop('NVTE_UNFUSED_ATTN', None) | ||
| Utils.destroy_model_parallel() | ||
| Utils.initialize_model_parallel(tensor_model_parallel_size=min(2, Utils.world_size)) |
7b4bb6b to
95aeafe
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing