Add hetero MIMO DDP performance flags#24
Draft
yashaswikarnati wants to merge 1 commit into
Draft
Conversation
yashaswikarnati
commented
May 14, 2026
| LLM_EXPT_TP="${LLM_EXPT_TP:-1}" | ||
| ENABLE_EXPERIMENTAL="${ENABLE_EXPERIMENTAL:-1}" | ||
| MOE_ROUTER_FORCE_LOAD_BALANCING="${MOE_ROUTER_FORCE_LOAD_BALANCING:-0}" | ||
| OVERLAP_GRAD_REDUCE="${OVERLAP_GRAD_REDUCE:-0}" |
Owner
Author
There was a problem hiding this comment.
can we default to 1? as we need them for perf ?
Owner
Author
There was a problem hiding this comment.
Done: defaulted OVERLAP_GRAD_REDUCE to 1 in the HEL 54L run script.
yashaswikarnati
commented
May 14, 2026
| MOE_ROUTER_FORCE_LOAD_BALANCING="${MOE_ROUTER_FORCE_LOAD_BALANCING:-0}" | ||
| OVERLAP_GRAD_REDUCE="${OVERLAP_GRAD_REDUCE:-0}" | ||
| OVERLAP_PARAM_GATHER="${OVERLAP_PARAM_GATHER:-0}" | ||
| DDP_NUM_BUCKETS="${DDP_NUM_BUCKETS:-}" |
Owner
Author
There was a problem hiding this comment.
can we use the same defaults that we used for good perf ?
Owner
Author
There was a problem hiding this comment.
Done: set the run-script perf defaults to DDP_NUM_BUCKETS=8 with DDP_BUCKET_SIZE unset, matching the final tested config.
yashaswikarnati
commented
May 14, 2026
| OVERLAP_PARAM_GATHER="${OVERLAP_PARAM_GATHER:-0}" | ||
| DDP_NUM_BUCKETS="${DDP_NUM_BUCKETS:-}" | ||
| DDP_BUCKET_SIZE="${DDP_BUCKET_SIZE:-0}" | ||
| DDP_PAD_BUCKETS_FOR_HIGH_NCCL_BUSBW="${DDP_PAD_BUCKETS_FOR_HIGH_NCCL_BUSBW:-0}" |
Owner
Author
There was a problem hiding this comment.
enable by default ?
Owner
Author
There was a problem hiding this comment.
Done: enabled DDP_PAD_BUCKETS_FOR_HIGH_NCCL_BUSBW by default in the HEL 54L run script.
yashaswikarnati
force-pushed
the
ykarnati/nmfw-464-ddp-perf-flags
branch
from
6b73a4c to
ab585d7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing