🧹 [code health] Replace bare except handlers with except Exception#541
Conversation
…lation Updated multiple locations in py2v_transpiler/core/translator/functions_split/generation.py and visitor.py to use 'except Exception:' instead of bare 'except:'. This prevents catching system-level exceptions like KeyboardInterrupt. Co-authored-by: yaskhan <3676373+yaskhan@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
🎯 What: Replaced bare
except:blocks withexcept Exception:inpy2v_transpiler/core/translator/functions_split/generation.pyandvisitor.py.💡 Why: Bare
except:catch-all blocks are generally discouraged in Python as they can inadvertently catch system-level exceptions likeKeyboardInterruptorSystemExit. Usingexcept Exception:ensures only standard exceptions are caught, improving maintainability and reliability.✅ Verification: Ran the full test suite (
pytest), and all 910 tests passed. Confirmed no bareexcept:blocks remain in the modified files viagrep.✨ Result: Improved code health and safety by preventing accidental suppression of system-level signals.
PR created automatically by Jules for task 11137691267388247807 started by @yaskhan