fix: Remove duplicate chevron in OllamaModelField menu#636
Merged
yazins-ai merged 4 commits intoMay 23, 2026
Merged
Conversation
The DisclosureGroup label only registered taps on the text and chevron. Added a full-width HStack with Spacer and used the padding/-padding trick to extend contentShape into the Form row's vertical insets, making the entire light-colored rectangle tappable. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
The borderlessButton menu style renders its own indicator chevron, while the label already contained an explicit chevron.down icon, resulting in two chevrons appearing side by side. Added .menuIndicator(.hidden) to suppress the automatic one. Affects all three Ollama model pickers: Notes Generation, Knowledge Base Retrieval, and Classic Suggestions. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
jasnoorgill
force-pushed
the
fix/ollama-model-field-double-chevron
branch
from
67008b5 to
9f9d1f7
Compare
yazins-ai
added
kind:ux
Collaborator
|
Thanks @jasnoorgill. The shared Ollama model picker fix is a clean one-liner and removes the double-chevron glitch everywhere that component is used. |
yazins-ai
added
state:done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The Ollama model selector dropdown was showing two chevrons side by side. The
borderlessButtonmenu style automatically renders its own indicator arrow, but the label already contained an explicitchevron.downicon — causing the duplication.Fix: Added
.menuIndicator(.hidden)to suppress the automatic indicator, leaving only the intentional custom icon.Since
OllamaModelFieldis a shared component, this fixes the double chevron in all three places it appears:One-line change in
OllamaModelField.swift.