forked from googlearchive/pywebsocket
-
Notifications
You must be signed in to change notification settings - Fork 0
CodeReviewInstruction
hiroshige-g edited this page Aug 31, 2015
·
3 revisions
pywebsocket uses pull requests for reviewing.
- Fork pywebsocket, create a branch, commit modifications, and create/send a pull request. For how to create and send pull requests, see for example Using pull requests.
- Get an LGTM from the collaborators of pywebsocket.
- The collaborators of pywebsocket merge the pull request.
cd to the root directory of the repository, and run
$ python test/run_all.py --log_level debug -- -v
Run pep8
$ pep8 --repeat **/*.py
Update version in setup.py, and commit.
Announce on the pywebsocket group.
Update the revision number part in the rule for pywebsocket
http://trac.webkit.org/wiki/pywebsocket%3A%20a%20WebSocket%20server%20for%20layout%20tests