Skip to content

Allow inline comments in configuration file - #94

Closed
dionysius wants to merge 1 commit into
yboetz:masterfrom
dionysius:inline_comments
Closed

dionysius wants to merge 1 commit into
yboetz:masterfrom
dionysius:inline_comments

Conversation

@dionysius

@dionysius dionysius commented Jan 9, 2023 •

Copy link
Copy Markdown

Cherry picked from #82.

  1. So discussion and review is on a per feature basis
  2. I see this as a really good QoL change
  • I don't see why any value would have a # sign
  1. smaller PR, easier to review
  2. due to cherry-pick will not break original PR

@dionysius

Copy link
Copy Markdown
Author

Damn, the cherry-pick is not enough. There are changes in various files regarding comments necessary. Ignore me

@dionysius dionysius closed this Jan 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants