Skip to content

Fix Slack bot-ID mentions without racing app mentions - #1040

Open
time-attack wants to merge 1 commit into
yc-software:mainfrom
time-attack:fix/slack-bot-id-mentions
Open

Fix Slack bot-ID mentions without racing app mentions#1040
time-attack wants to merge 1 commit into
yc-software:mainfrom
time-attack:fix/slack-bot-id-mentions

Conversation

@time-attack

@time-attack time-attack commented Sep 10, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • recognize Slack's bot-ID mention form alongside the bot-user-ID form in shared mention parsing, stripping, mirroring, and history rendering
  • route validated human-authored bot-ID-only messages through the existing addressed-turn path without racing normal app_mention delivery
  • establish thread stake only after accepted fallback intake, keeping rejected/failed/peer-bot cases fail-closed
  • add rate-limited acceptance diagnostics and preserve existing local/durable dedupe keys

Fixes #630.

Test plan

  • node --experimental-test-module-mocks --test --test-concurrency=2 test/slack-*.test.ts test/admin-slack-mirror.test.ts test/external-slack-participants.test.ts test/surface-cache*.test.ts test/loop-source-send.test.ts test/loop-ledger.test.ts (701 passed)
  • npm run typecheck
  • targeted ESLint and Oxlint on all 12 changed files
  • targeted Prettier check on all 12 changed files
  • git diff --cached --check

Live Slack client/event fan-out and real PostgreSQL multi-process replay remain follow-up validation; the added suites cover both event orders, retries, failed author classification, peer-bot negatives, concurrent intake, and accepted-versus-rejected thread stake.


View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need. Autofix is disabled.

@time-attack
time-attack force-pushed the fix/slack-bot-id-mentions branch from d485a04 to dbf83ed Compare September 10, 2026 00:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bot-id-form channel mentions (<@B…>) aren't recognized: top-level ones are silently dropped, in-thread ones misfire as ambient

1 participant