fix: accept custom models the web picker already offers - #980
Open
siddiqueirshad wants to merge 1 commit into
Open
fix: accept custom models the web picker already offers#980siddiqueirshad wants to merge 1 commit into
siddiqueirshad wants to merge 1 commit into
Conversation
Web turns with no org allowlist and no OpenRouter key fell back to the built-in DEFAULT_WEBUI_MODEL_IDS set, so admin-registered custom models that the picker listed were refused as HTTP 403. Fixes yc-software#952 Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
With no web-UI allowlist and no OpenRouter key,
GET /v1/surface-configstill lists admin-registered custom models (frombuiltInModelCatalog()). Sending a turn on one of those models was refused:validateWebTurnModelOptionsfell back toDEFAULT_WEBUI_MODEL_IDS, which never includes custom ids.postTurnmaps that refusal to HTTP 403.That is the documented custom-provider path. The picker and the gate disagreed.
Fixes #952
What
builtInModelCatalog, or the OpenRouter catalog when that key is present) instead of leaving the allowlistnull.Tests
that model is not enabled for the web UI.test/turn-options.test.ts,test/custom-providers.test.ts,test/custom-provider-route.test.ts,test/model-registry.test.ts— 33 passed.Made with Cursor
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.