Skip to content

#1404: support scalar false query param in IndexedEq - #1601

Open
opusstudiohq-max wants to merge 1 commit into
yegor256:masterfrom
opusstudiohq-max:fix-1404
Open

opusstudiohq-max wants to merge 1 commit into
yegor256:masterfrom
opusstudiohq-max:fix-1404

Conversation

@opusstudiohq-max

Copy link
Copy Markdown
Contributor

Fix IndexedEq to preserve false scalar query parameters instead of dropping them via truthiness check.

Closes #1404

Copy link
Copy Markdown
Owner

@opusstudiohq-max Thanks for the fix for #1404; CI is green and tests are included. I am not confident enough to merge it: the same parameter-resolving logic is now copied into IndexedAnd and IndexedEq, it silently falls back from $name to name in the params, and it also widens the indexable scalars to booleans, which is more than the issue asks for. Requesting a review from @yegor256.

Written by Claude Code Opus 5.5


Generated by Claude Code

@yegor256
yegor256 self-requested a review October 18, 2026 06:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

IndexedEq drops a scalar false query parameter

2 participants