Skip to content

Replace panic with error return #145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yeqown merged 1 commit into from
Mar 10, 2026
Merged

Replace panic with error return #145

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions encoder.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,9 @@ func (e *encoder) Encode(byts []byte) (*binary.Binary, error) {
}

// fill and _defaultPadding bits
e.breakUpInto8bit()
if err := e.breakUpInto8bit(); err != nil {
return nil, err
}

return e.dst, nil
}
Expand Down Expand Up @@ -178,7 +180,7 @@ func (e *encoder) encodeByte() {
}

// Break Up into 8-bit Codewords and Add Pad Bytes if Necessary
func (e *encoder) breakUpInto8bit() {
func (e *encoder) breakUpInto8bit() error {
// fill ending code (max 4bit)
// depends on max capacity of current version and EC level
maxCap := e.version.NumTotalCodewords() * 8
Expand All @@ -187,7 +189,7 @@ func (e *encoder) breakUpInto8bit() {
"wrong version(%d) cap(%d bits) and could not contain all bits: %d bits",
e.version.Ver, maxCap, e.dst.Len(),
)
panic(err)
return err
} else if less < 4 {
e.dst.AppendNumBools(less, false)
} else {
Expand All @@ -211,6 +213,7 @@ func (e *encoder) breakUpInto8bit() {
}
}
}
return nil
}

// 字符计数指示符位长字典
Expand Down
Loading