Merged
Conversation
ncaq
requested changes
Jan 9, 2026
parsonsmatt
reviewed
Jan 9, 2026
serversession-backend-persistent/serversession-backend-persistent.cabal
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Pull request overview
This PR updates the serversession-backend-persistent library to support persistent 2.17 by making necessary code changes and updating dependency bounds. The changes are driven by upstream persistent library modifications that introduced a new entitySpan field in the EntityDef record.
Changes:
- Updated Stack LTS resolver from 19.5 to 24.11 to include persistent 2.17
- Added
entitySpanfield toEntityDefrecord construction in the PersistEntity instance - Updated persistent dependency upper bound from 2.15.0.0 to 2.18.0.0
- Added import of
Database.Persist.TH.Internalin example application to supportembedEntityDefs
Reviewed changes
Copilot reviewed 4 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| stack.yaml.lock | Updated LTS snapshot from 19.5 to 24.11 with new persistent versions |
| stack.yaml | Updated resolver to lts-24.11 |
| serversession-backend-persistent/src/Web/ServerSession/Backend/Persistent/Internal/Impl.hs | Added entitySpan = Nothing field to EntityDef record to comply with persistent 2.17 API |
| serversession-backend-persistent/serversession-backend-persistent.cabal | Bumped version to 2.0.4 and updated persistent upper bound to < 2.18.0.0 |
| serversession-backend-persistent/changelog.md | Added changelog entry for version 2.0.4 |
| examples/serversession-example-yesod-persistent/Application.hs | Added import of Database.Persist.TH.Internal module for embedEntityDefs function |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ncaq
added
Priority: High
Type: Dependencies
m1-s
commented
Jan 14, 2026
serversession-backend-persistent/src/Web/ServerSession/Backend/Persistent.hs
Show resolved
Hide resolved
Collaborator
|
Oh, I want to pass CI or write test bug. |
m1-s
force-pushed
the
update
branch
3 times, most recently
from
525123f to
a258ae8
Compare
Contributor
Author
|
I made some more changes to fix compiler warnings. I hope CI works now. I can not run the test suite locally because it depends on a running postgresql database. |
ncaq
requested changes
Jan 16, 2026
Contributor
Author
|
yes |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update for changes introduced by yesodweb/persistent#1569