Manual upload - #115
Open
invaliduser wants to merge 16 commits into
Open
Conversation
invaliduser
marked this pull request as ready for review
March 10, 2026 18:17
cliffcaseyyet
left a comment
cliffcaseyyet
left a comment
Member
There was a problem hiding this comment.
Looks good, but suggesting the following:
-
Don't validate xAPI and json separately because its misleading to user, see slack discussion.
-
Put some kind of CSS box around the editor
-
Put some kind of header above it like "manual statement entry"
milt
approved these changes
Mar 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before choosing an API key:
After choosing a key:
JSON error (manual):
JSON error (file upload, blanks editor when this happens):
valid statements:
After upload:
