example for test cases#307
Open
cvanelteren wants to merge 5 commits into
Open
Conversation
Owner
|
Thank you! Could you please integrate it into the tests by renaming your file to start with "t" letter, and getting rid of malebolgia dependency? |
Author
|
Threading is not native anymore to Nim. I could write a unit test but sure
how to test it without specific packages. Threading module I think is
deprecated -- but I could be mistaken.
|
Contributor
|
Threads are in the stdlib as https://nim-lang.org/docs/typedthreads.html#examples 😄 |
Author
|
A bit late but I will update this in the next days. |
* add init, del, repr, doc for pyType * add a export type test * minor fix on the test case * use 2 spaces rather than 4 spaces * use 2 spaces rather than 4 spaces * remove __del__ --------- Co-authored-by: Wei Xiang <wxiang@wxtrades.wxtrades.com>
Author
|
@yglukhov done! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To provide more context on #304 and #21