Conversation
A full rescan of this archive is a ~13-hour NFS find, so the tool's 24 h cache expiry spends half of every day scanning. Weekly keeps the freshness guarantee bounded (~40 new videos accumulate per week at observed rates, a few hours of GPU work) at 1/7th the scan load. Overridable via the SCAN_CACHE_MAX_AGE_HOURS env var.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Team Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughSummary by CodeRabbit
WalkthroughThe archive transcriber script adds a ChangesArchive transcriber cache
Estimated code review effort: 1 (Trivial) | ~5 minutes Merge Risk: ⚪ Minimal · up to The archive launcher will reuse scan results for up to 168 hours by default, reducing expensive rescans while allowing an environment override. The behavior is bounded and validated, and no actionable merge-blocking risk remains beyond normal checks and review. Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Full details: Docstring CoverageExplanation No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1 files. ✨ Finishing Touches📝 Generate docstrings
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
🟢 Approval recommended
The change is a small, well-scoped deployment-script adjustment that uses an existing, tested CLI flag and preserves safe override behavior via environment variables.
Pull request overview
Updates the archive transcriber deployment script to reduce expensive NFS rescans by extending the scan-cache expiry window for this specific large archive, while keeping the tool’s default behavior unchanged.
Changes:
- Introduces
SCAN_CACHE_MAX_AGE_HOURSin the run script with a default of 168 hours (weekly), overridable via environment. - Passes
--scan-cache-max-age-hoursthrough toarchive_transcriber.pyto enforce the weekly cache policy at runtime.
File summaries
| File | Description |
|---|---|
| scripts/run_archive_transcriber.sh | Sets a weekly scan-cache max age (env-overridable) and forwards it to the transcriber CLI to avoid daily full NFS rescans. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
A full rescan of this archive is a ~13-hour NFS
find(measured twice: 11h48m on Aug 30, 13h on Sep 1), so the tool's 24-hour cache expiry spends roughly half of every day scanning.This sets
SCAN_CACHE_MAX_AGE_HOURS=168in the run script (overridable via env), keeping the freshness guarantee bounded: ~40 new videos accumulate per week at observed rates (1,219 over the 31 weeks the stale cache hid them), which is a few hours of GPU work per weekly rescan.The tool default stays at 24h — this is a deployment decision for this archive's size, expressed where the deployment lives.
No code changes;
bash -nclean.