-
-
Notifications
You must be signed in to change notification settings - Fork 13
Refactor ColumnDefinitionParser
#381
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #381 +/- ##
============================================
- Coverage 98.00% 95.85% -2.15%
- Complexity 242 243 +1
============================================
Files 26 26
Lines 803 821 +18
============================================
Hits 787 787
- Misses 16 34 +18 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR refactors the ColumnDefinitionParser class to align with changes in the parent yiisoft/db package. The refactoring replaces the old ColumnDefinitionParser base class with AbstractColumnDefinitionParser and introduces a new parseTypeParams() method to handle type-specific parameter parsing. This change removes the conditional enum handling logic in favor of a cleaner type-matching approach.
Key changes:
- Changes parent class from
ColumnDefinitionParsertoAbstractColumnDefinitionParser - Removes conditional enum/size info parsing logic in favor of direct
parseSizeInfo()call - Adds new
parseTypeParams()method with explicit type handling using match expression
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/Column/ColumnDefinitionParser.php | Refactored to extend AbstractColumnDefinitionParser and implement parseTypeParams() method for Oracle-specific type parameter handling |
| CHANGELOG.md | Added changelog entry for the refactoring |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Related to yiisoft/db#1108