Skip to content

Conversation

@vjik
Copy link
Member

@vjik vjik commented Nov 25, 2025

Q A
Is bugfix?
New feature?
Breaks BC? ✔️

Related to yiisoft/db#1108

@codecov
Copy link

codecov bot commented Nov 25, 2025

Codecov Report

❌ Patch coverage is 18.18182% with 18 lines in your changes missing coverage. Please review.
✅ Project coverage is 95.85%. Comparing base (dbb5dce) to head (f875e9c).
⚠️ Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
src/Column/ColumnDefinitionParser.php 18.18% 18 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master     #381      +/-   ##
============================================
- Coverage     98.00%   95.85%   -2.15%     
- Complexity      242      243       +1     
============================================
  Files            26       26              
  Lines           803      821      +18     
============================================
  Hits            787      787              
- Misses           16       34      +18     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR refactors the ColumnDefinitionParser class to align with changes in the parent yiisoft/db package. The refactoring replaces the old ColumnDefinitionParser base class with AbstractColumnDefinitionParser and introduces a new parseTypeParams() method to handle type-specific parameter parsing. This change removes the conditional enum handling logic in favor of a cleaner type-matching approach.

Key changes:

  • Changes parent class from ColumnDefinitionParser to AbstractColumnDefinitionParser
  • Removes conditional enum/size info parsing logic in favor of direct parseSizeInfo() call
  • Adds new parseTypeParams() method with explicit type handling using match expression

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
src/Column/ColumnDefinitionParser.php Refactored to extend AbstractColumnDefinitionParser and implement parseTypeParams() method for Oracle-specific type parameter handling
CHANGELOG.md Added changelog entry for the refactoring

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@vjik vjik requested review from a team and samdark November 25, 2025 21:37
@vjik vjik added status:code review The pull request needs review. status:under development Someone is working on a pull request. and removed status:code review The pull request needs review. labels Nov 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status:under development Someone is working on a pull request.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants