Skip to content

Conversation

@dehbka
Copy link
Contributor

@dehbka dehbka commented Sep 4, 2024

Q A
Is bugfix?
New feature?
Breaks BC? ✅ break php < 8
Fixed issues 60

@codecov
Copy link

codecov bot commented Sep 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (c9e5f58) to head (f98ba54).
Report is 1 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##              master       #62   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
  Complexity        36        36           
===========================================
  Files              7         7           
  Lines            103       103           
===========================================
  Hits             103       103           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@vjik vjik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adapt code to PHP 7.4. Seems, need to put PHP attribute to separate line.

@vjik vjik added the status:code review The pull request needs review. label Feb 25, 2025
@vjik vjik requested a review from a team February 25, 2025 12:48
@vjik vjik merged commit 292f4e0 into yiisoft:master Feb 25, 2025
26 checks passed
@vjik vjik mentioned this pull request Feb 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status:code review The pull request needs review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants