Fix #591: Add `File` validator by samdark · Pull Request #797 · yiisoft/validator

samdark · 2026-04-23T18:54:31Z

Q	A
Is bugfix?	❌
New feature?	✔️
Breaks BC?	❌

…validator

Copilot

Pull request overview

Adds a new File validation rule/handler to the validator package and extends the existing Image rule handler to accept SplFileInfo inputs (and to be more robust with UploadedFileInterface stream metadata failures).

Changes:

Introduce Yiisoft\Validator\Rule\File and Yiisoft\Validator\Rule\FileHandler with validation for file existence plus optional extension, MIME type, and size constraints.
Extend ImageHandler to accept SplFileInfo values and gracefully handle RuntimeException when resolving an uploaded file stream URI.
Add/extend PHPUnit coverage and fixtures for the new File rule and Image updates; update docs index and changelog.

Reviewed changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
tests/Rule/Image/ImageTest.php	Adds coverage for `SplFileInfo` support and missing-temp-path upload behavior in `Image`.
tests/Rule/FileTest.php	New comprehensive test suite for the `File` rule/handler.
tests/Rule/File/notes.txt	Text fixture used for MIME/size checks.
tests/Rule/File/README	Fixture for “file without extension” scenarios.
src/Rule/Image/ImageHandler.php	Adds `SplFileInfo` support and handles stream URI runtime exceptions.
src/Rule/FileHandler.php	New handler implementing file validation logic for paths, `SplFileInfo`, and PSR-7 uploads.
src/Rule/File.php	New rule defining options/messages and normalization for extensions & MIME types.
docs/guide/en/built-in-rules.md	Adds `File` to the built-in rules list.
CHANGELOG.md	Records enhancement #591.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot

Pull request overview

Adds a new built-in File validation rule (and handler) to the Yiisoft Validator, enabling validation of file inputs with optional constraints (extensions, MIME types, and size), along with full test coverage and documentation/changelog updates.

Changes:

Introduce Yiisoft\Validator\Rule\File rule with configurable extension/MIME/size constraints and messages.
Add Yiisoft\Validator\Rule\FileHandler implementing the validation logic for file paths, SplFileInfo, and UploadedFileInterface.
Add comprehensive PHPUnit tests plus new fixture files; update docs index and changelog.

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
`src/Rule/File.php`	New `File` rule definition, options normalization, and messages.
`src/Rule/FileHandler.php`	New handler implementing validation for file existence, extension/MIME checks, and size constraints.
`tests/Rule/FileTest.php`	New unit tests covering configuration, normalization, pass/fail scenarios, messages, and integration cases.
`tests/Rule/File/notes.txt`	Test fixture used for size/MIME/extension cases.
`tests/Rule/File/README`	Extensionless test fixture.
`docs/guide/en/built-in-rules.md`	Adds `File` to the built-in rules list.
`CHANGELOG.md`	Records the new feature (#591).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot

Pull request overview

This PR adds a new built-in File validation rule to the Yiisoft Validator package, enabling validation of file paths, SplFileInfo, and PSR-7 UploadedFileInterface instances with optional checks for extension, MIME type (including wildcards), and size constraints.

Changes:

Introduced Yiisoft\Validator\Rule\File rule and Yiisoft\Validator\Rule\FileHandler implementation.
Added comprehensive unit tests and new test fixtures for file validation scenarios.
Updated documentation index and changelog to list the new built-in rule.

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
`src/Rule/File.php`	New `File` rule definition (options, messages, normalization, handler binding).
`src/Rule/FileHandler.php`	New handler implementing file detection and constraint validation (extension/MIME/size).
`tests/Rule/FileTest.php`	New test suite covering configuration errors, passing/failing validation cases, and warnings behavior.
`tests/Rule/File/README`	Fixture: file without extension.
`tests/Rule/File/notes.txt`	Fixture: plain text file for MIME/size checks.
`docs/guide/en/built-in-rules.md`	Adds `File` to the built-in rules list.
`CHANGELOG.md`	Documents the new feature addition (#591).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

vjik · 2026-04-24T14:42:14Z

+     *
+     * @see $mimeTypes
+     */
+    public function getMimeTypes(): ?array


Use promoted public readonly properties in constructor whenever possible.

vjik · 2026-04-24T14:45:17Z

+     *
+     * You may use the following placeholders in the message:
+     *
+     * - `{property}`: the translated label of the property being validated.


Add {Property}

vjik · 2026-04-24T14:45:21Z

+     *
+     * You may use the following placeholders in the message:
+     *
+     * - `{property}`: the translated label of the property being validated.


Add {Property}

vjik · 2026-04-24T14:48:06Z

+     *
+     * You may use the following placeholders in the message:
+     *
+     * - `{property}`: the translated label of the property being validated.


Add {Property}

vjik · 2026-04-24T14:48:13Z

+     *
+     * You may use the following placeholders in the message:
+     *
+     * - `{property}`: the translated label of the property being validated.


Add {Property}

vjik · 2026-04-24T14:48:47Z

+     *
+     * You may use the following placeholders in the message:
+     *
+     * - `{property}`: the translated label of the property being validated.


Add {Property}

vjik · 2026-04-24T14:48:58Z

+     *
+     * You may use the following placeholders in the message:
+     *
+     * - `{property}`: the translated label of the property being validated.


Add {Property}

vjik · 2026-04-24T14:50:09Z

+    use WhenTrait;
+
+    /**
+     * @var list<string>|null


Suggested change

* @var list<string>|null

* @var string[]|null

* @psalm-var list<string>|null

vjik · 2026-04-24T14:50:15Z

+    private ?array $extensions;
+
+    /**
+     * @var list<string>|null


Suggested change

* @var list<string>|null

* @var string[]|null

* @psalm-var list<string>|null

vjik · 2026-04-24T14:52:24Z

+    /**
+     * @psalm-param list<string>|string|null $value
+     *
+     * @return list<string>|null


Suggested change

* @return list<string>|null

* @return string[]|null

* @psalm-return list<string>|null

Fix #591: Add File validator, add SplFileInfo support to Image …

661ab45

…validator

samdark requested review from Copilot and vjik April 23, 2026 18:54

Copilot started reviewing on behalf of samdark April 23, 2026 18:55 View session

Copilot AI reviewed Apr 23, 2026

View reviewed changes

Comment thread src/Rule/FileHandler.php

samdark added 3 commits April 23, 2026 22:08

Fix edge case

b04e1b9

Remove Image validator changes from file branch

ff3c052

Adjust README

032b6e4

samdark changed the title ~~Fix #591: Add File validator, add SplFileInfo support to Image validator~~ Fix #591: Add File validator Apr 23, 2026

samdark requested a review from Copilot April 23, 2026 19:20

Copilot started reviewing on behalf of samdark April 23, 2026 19:20 View session

Copilot AI reviewed Apr 23, 2026

View reviewed changes

Comment thread src/Rule/FileHandler.php

Fix possible warnings in mime_content_type

d492496

samdark requested a review from Copilot April 23, 2026 21:59

Copilot started reviewing on behalf of samdark April 23, 2026 21:59 View session

Copilot AI reviewed Apr 23, 2026

View reviewed changes

Comment thread src/Rule/File.php

vjik added 2 commits April 24, 2026 10:43

Merge branch 'master' into feature/591-file-validator

d903013

Merge branch 'master' into feature/591-file-validator

8d847b6

vjik requested changes Apr 24, 2026

View reviewed changes

	* @var list<string>\|null
	* @var string[]\|null
	* @psalm-var list<string>\|null

	* @return list<string>\|null
	* @return string[]\|null
	* @psalm-return list<string>\|null

Uh oh!

Conversation

samdark commented Apr 23, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants