Match with enable logging and profiling#314
Conversation
ziaratban
commented
Jul 2, 2020
| Q | A |
|---|---|
| Is bugfix? | yes |
| New feature? | no |
| Breaks BC? | no |
| Tests pass? | yes |
see yii\mongodb\Connection::enableLogging and yii\mongodb\Connection::enableProfiling
|
main purpose |
Co-authored-by: Alexander Makarov <sam@rmcreative.ru>
Co-authored-by: Alexander Makarov <sam@rmcreative.ru>
Co-authored-by: Alexander Makarov <sam@rmcreative.ru>
Co-authored-by: Alexander Makarov <sam@rmcreative.ru>
Co-authored-by: Alexander Makarov <sam@rmcreative.ru>
Co-authored-by: Alexander Makarov <sam@rmcreative.ru>
Co-authored-by: Alexander Makarov <sam@rmcreative.ru>
Co-authored-by: Alexander Makarov <sam@rmcreative.ru>
Co-authored-by: Alexander Makarov <sam@rmcreative.ru>
base on : yiisoft#314
|
https://travis-ci.com/github/yiisoft/yii2-mongodb/jobs/357995598#L1572 - fails tests on connection. |
70d76cc to
1e760fe
Compare
@samdark please see |
|
@ziaratban referencing Yii::$app->mongodb is incorrect. You should use connection. |
fixed. |
|
Seems tests aren't alright with new code. |
I think this is about test case. (#316 ) |
No, it should not be since tests are alright in master branch. |
|
i merged branch |
|
The change looks valid, yes. I wonder why tests do pass then in master. Must be uncovered case... |
|
No, I think no uncovered cases exist. A wrong direction has gone through, across the 'test case' project. Mongodb's component is not used. Docs say this about the
|
61e732c to
dd7c555
Compare