Fix moving to next input with tab key#8
Open
cvuorinen wants to merge 1 commit into
Open
Conversation
Do not trigger the popup when "hot key" pressed if model has value Preserve normal behavior for tab, enter and esc keys by not triggering the popup if there is already a value selected.
|
I can confirm this fixes the issue. |
|
Can we hope for this to be merged soon? |
Author
|
Ping @yohairosen |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Preserve normal behavior for tab, enter and esc keys by not triggering the popup if there is already a value selected.
Previously tab key wasn't working properly with this directive as pressing tab key didn't move to next input field but just triggered the typeahead popup again. Same with enter and esc keys, previously they would just blink and trigger the popup again.
Fixes http://stackoverflow.com/questions/24764802/angular-js-automatically-focus-input-and-show-typeahead-dropdown-ui-bootstra#comment55759378_27331340