Scythe update#68
Open
UnknownPerson-cmd wants to merge 1 commit into
Open
Conversation
chickemeeple
requested changes
Aug 18, 2025
Collaborator
chickemeeple
left a comment
chickemeeple
left a comment
There was a problem hiding this comment.
A few things need to be changed.
1, packages/junon-io/server/entities/equipments/scythe.js needs to be moved to packages/junon-io/server/entities/equipments/hand
2, in the clientside scythe.js, you are trying to define a Pitchfork class instead of scythe.
3, in packages/junon-io/client/src/entities/game.js, there is an array called tempAssets. since the scythe image isn't inside one of the atlases, you'll need to add it to this array in order to index it.
4, client won't compile. not sure if this is related to the above 3 issues, but fix those and I'll review it again.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
changed from pitchfork to scythe Wahlee made art same code inside except swapped names