Bound the address before narrowing it in mbusctl - #5
Merged
Merged
Conversation
The valid-range check guaranteed the value fits in a byte, but only through a disjunction. An explicit byte-range check before the conversion is robust against future edits to the valid set.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Code scanning flagged the int to uint8 conversion in
destinationAddr. The valid-range check did guarantee the value fits in a byte, but only through a disjunction, which static analysis cannot follow and which is fragile if the valid set ever changes. The conversion now happens after an explicit byte-range check.