Repository navigation
docs(renovate): stop naming mongkn as the counter-example - #85
Merged
Merged
Conversation
The preset's precondition paragraph told readers to go and look at what runs on `pull_request`, and then handed them a ready-made example so they would not have to: mongkn, whose build workflow was `workflow_dispatch` only. Its triggers went back on. This text did not notice, and went on citing a reason that had expired — in the very paragraph that exists to say do not take such a reason on trust. The example is now written as what it is, past tense, with that outcome as the second half of the lesson.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The precondition paragraph in
automerge-harness.jsontells the reader to go and look at what runs onpull_request— and then hands them a ready-made example so they do not have to: mongkn, whose build workflow wasworkflow_dispatchonly.mongkn's triggers went back on. This text did not notice, and kept citing a reason that had expired — inside the very paragraph whose point is that such a reason must not be taken on trust.
So the example is rewritten as what it is: past tense, with that outcome as the second half of the lesson. The instruction now reads "look at what runs on
pull_requestin the repository doing the extending — in the workflow, not in a sentence about it."Pairs with youndie/mongkn#25, which extends the preset there now that its precondition holds.