Repository navigation
feat(samples): add a Compose app that writes to tracy, measure it - #93
Merged
Merged
Conversation
The threshold is committed before the first build is measured, so it cannot move to meet the number: at most 10 percent on the gzipped .wasm of the same Compose app built without the agent. Refs: M-148
The client line had a test from app to service but no app. This one writes with a client key, opens a trace around a button press, records a degraded screen with an indexed field and flushes on leaving; built with and without the agent it answers the pre-registered size question: +5.0 percent of the gzipped wasm. Refs: M-148
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
M-148 (research-clients, open question 1).
Two commits on purpose. The first,
docs(samples): pre-register…, states the threshold before anything was built: the agent may add at most 10 % to the gzipped.wasmof the same app without it. It was pushed alone first (as7c81698, rebased onto #92 asd21a5bewith its author date kept), so the number could not move the threshold.The sample (
samples/compose-app, a build of its own taking the agent from this checkout viaincludeBuild): desktop and browser. Two buttons — one opens a trace withaction("order.open"), one records a screen that drew a placeholder, withoriginalTypeas an indexed field. Client key,maxBatchBytesunder the client ceiling,flushWhenBackgrounded().-Ptracy.agent=falsebuilds the same app with the telemetry compiled to nothing.Result (
MEASUREMENT.md): all.wasmgzipped, 3 900 869 B without the agent, 4 096 779 B with it — +195 910 B, +5.0 %, under the threshold. Also written down: against the app's own.wasmwithout skiko it is +34 %; skiko is 85 % of the first download here.Checked by hand in a browser against a local
server.kexewithTRACY_CLIENT_KEYS: the page sentOPTIONS /ingest→ 204 (#89) and twoPOST /ingest→ 202; the database held serviceapp:compose-app(the header saidcompose-app, the key decided — #86), a root spanorder.open(#87), the warning withuntrusted = 1, and the entity referenceoriginalType = promo-carousel-v3. Desktop, Android and iOS were not run against a server.Found on the way: the first page was blank —
ComposeViewport(document.body)fills an unstyled body that is 0 px tall.index.htmlnow sizes it. The shildik sample (youndie/shildik#73) carries the same file and gets the same fix separately..github/workflows/sample.ymlbuilds both variants when the sample, the agent or the wire change.