[FEAT#315] 끗장 뱃지 표시, 나다움 내역 UI 개선#316
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Walkthrough끗장 뱃지를 표시하기 위해 새 Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~15 minutes Possibly related PRs
Suggested labels
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
🔨 빌드 상태: 성공! ✅프론트엔드 빌드가 성공적으로 완료되었습니다! 🎉 ✅ 체크 완료
📊 상세 정보
|
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@fe/src/app/`(main)/store/history/nadaum/page.tsx:
- Around line 208-277: The icon-only ButtonBase used to open the period filter
(the ButtonBase wrapping ListFilterIcon and invoking
setSelectedPeriod(appliedPeriod); setIsPeriodFilterOpen(true)) lacks an
accessible name; add an appropriate aria-label (e.g., "Open period filter" or
localised "기간 필터 열기") to that ButtonBase so screen readers can convey its
purpose.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 작업 내용
🎯 관련 이슈
Closes #315
Summary by CodeRabbit
새로운 기능
✏️ Tip: You can customize this high-level summary in your review settings.