Conversation
Closed
1 task
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Walkthrough댓글, 좋아요 알림에서 작성자 표시명을 결정하는 로직을 변경했어. 기존의 Changes
Sequence Diagram(s)sequenceDiagram
participant System as 알림 시스템
participant Post as Post/Community<br/>Data
participant User as Users<br/>Collection
participant NickGlobal as Global<br/>Nicknames
participant NickCom as Community<br/>Member Data
rect rgba(255, 200, 100, 0.5)
Note over System: 기존 흐름: isPublic 기반 분기
System->>Post: post.isPublic 확인
alt 공개 게시글
System->>NickGlobal: 글로벌 닉네임 조회
NickGlobal-->>System: 닉네임 반환
else 비공개 게시글
System->>User: 실명 조회
User-->>System: 실명 반환
end
end
rect rgba(100, 200, 255, 0.5)
Note over System: 새 흐름: programType 기반 분기
System->>Post: programType 확인
alt TMI 프로젝트
System->>User: 실명 조회
User-->>System: 실명 반환
else 일반 프로젝트
System->>NickCom: 커뮤니티 멤버 닉네임 조회
alt 멤버 닉네임 존재
NickCom-->>System: 멤버 닉네임 반환
else 멤버 닉네임 없음
System->>NickGlobal: 글로벌 닉네임 조회
alt 글로벌 닉네임 존재
NickGlobal-->>System: 글로벌 닉네임 반환
else 글로벌 닉네임 없음
System->>User: 사용자 이름 조회
User-->>System: 사용자 이름 반환
end
end
end
end
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
🔧 빌드 상태: 성공! ✅Firebase Functions 빌드 및 에뮬레이터 기동이 성공적으로 완료되었습니다! 🎉 ✅ 체크 완료
📊 상세 정보
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 작업 내용
🎯 관련 이슈
Closes #320
Summary by CodeRabbit
버그 수정
✏️ Tip: You can customize this high-level summary in your review settings.