fix: main 600 사용하는 곳들 main 500 적용#330
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Walkthrough버튼, 텍스트, 테두리 등의 색상 클래스를 일괄 변경한 PR이야. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Possibly related PRs
Suggested labels
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
🔨 빌드 상태: 성공! ✅프론트엔드 빌드가 성공적으로 완료되었습니다! 🎉 ✅ 체크 완료
📊 상세 정보
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Fix all issues with AI agents
In `@fe/src/components/community/CommentItem.tsx`:
- Line 1083: In CommentItem.tsx there are inconsistent tailwind classes: the
reply-edit button (답글 수정 버튼) and the nested-reply submit button (대댓글 제출 버튼)
still use "bg-main-600 hover:bg-main-700"; update their JSX className values in
the CommentItem component to match the updated style "bg-main-500
hover:bg-main-600 cursor-pointer text-white" so all same-role buttons share the
same appearance and hover behavior.
In `@fe/src/components/mission/mission-certification-success-modal.tsx`:
- Line 47: The "다음 미션 찾아보기" button inside the MissionCertificationSuccessModal
still uses bg-main-600 hover:bg-main-700 while the checkmark background was
changed to bg-main-500; update the button's class names in
mission-certification-success-modal.tsx (the button with the label "다음 미션 찾아보기")
to use bg-main-500 and an appropriate hover (e.g., hover:bg-main-600) so the
modal uses a consistent main color scheme.
🧹 Nitpick comments (1)
fe/src/app/(main)/store/[id]/purchase/page.tsx (1)
435-442: 색상 변경 OK, 근데 hover 상태는 어때?
bg-main-500으로 잘 변경됐는데, 이 버튼은hover상태가 없네. 위에buttonBaseClass에는hover:bg-main-600이 있는데 여기엔 빠져있어서 UX 일관성 측면에서 살짝 아쉬울 수 있어.물론 수량 에러 페이지라서 자주 보일 화면은 아니니까 지금 당장 안 바꿔도 되긴 해! 나중에 시간 나면 맞춰주면 좋을 듯 👀
♻️ hover 상태 추가 제안
<button onClick={() => router.push(`/store/${productId}`)} - className="bg-main-500 rounded-lg px-4 py-2 text-white" + className="bg-main-500 rounded-lg px-4 py-2 text-white transition-colors hover:bg-main-600" >
| "flex h-8 items-center rounded-lg px-3 py-2 transition-all", | ||
| hasEditContent | ||
| ? "bg-main-600 hover:bg-main-700 cursor-pointer text-white" | ||
| ? "bg-main-500 hover:bg-main-600 cursor-pointer text-white" |
There was a problem hiding this comment.
일부만 변경돼서 불일치가 생겼어!
여기 댓글 수정 버튼은 bg-main-500 hover:bg-main-600으로 잘 바꿨는데, 같은 파일 내 다른 버튼들이 안 바뀌었어:
- Line 1329: 답글 수정 버튼 - 아직
bg-main-600 hover:bg-main-700 - Line 1476: 대댓글 제출 버튼 - 아직
bg-main-600 hover:bg-main-700
같은 역할을 하는 버튼들인데 색상이 다르면 UX 일관성이 깨지니까 함께 수정해줘!
🔧 누락된 부분 수정 제안
Line 1329:
hasEditContent
- ? "bg-main-600 hover:bg-main-700 cursor-pointer text-white"
+ ? "bg-main-500 hover:bg-main-600 cursor-pointer text-white"
: "cursor-not-allowed bg-gray-100 text-gray-400 opacity-50"Line 1476:
!isCommentSubmitting && hasReplyToReplyContent
- ? "bg-main-600 hover:bg-main-700 cursor-pointer text-white"
+ ? "bg-main-500 hover:bg-main-600 cursor-pointer text-white"
: "cursor-not-allowed bg-gray-100 text-gray-400 opacity-50"🤖 Prompt for AI Agents
In `@fe/src/components/community/CommentItem.tsx` at line 1083, In CommentItem.tsx
there are inconsistent tailwind classes: the reply-edit button (답글 수정 버튼) and
the nested-reply submit button (대댓글 제출 버튼) still use "bg-main-600
hover:bg-main-700"; update their JSX className values in the CommentItem
component to match the updated style "bg-main-500 hover:bg-main-600
cursor-pointer text-white" so all same-role buttons share the same appearance
and hover behavior.
| {/* 체크마크 아이콘 */} | ||
| <div className="flex justify-center"> | ||
| <div className="bg-main-600 flex size-16 items-center justify-center rounded-full"> | ||
| <div className="bg-main-500 flex size-16 items-center justify-center rounded-full"> |
There was a problem hiding this comment.
여기도 일부만 변경됐어!
체크마크 아이콘 배경은 bg-main-500으로 잘 바꿨는데, 바로 아래 "다음 미션 찾아보기" 버튼(Line 83)은 아직 bg-main-600 hover:bg-main-700으로 남아있어.
같은 모달 안에서 색상이 다르면 어색하니까 버튼도 함께 수정해주면 좋겠어!
🔧 누락된 부분 수정 제안
Line 83:
- className="bg-main-600 hover:bg-main-700 w-full rounded-lg py-2 text-white transition-colors focus:outline-none focus-visible:outline-2 focus-visible:outline-blue-500"
+ className="bg-main-500 hover:bg-main-600 w-full rounded-lg py-2 text-white transition-colors focus:outline-none focus-visible:outline-2 focus-visible:outline-blue-500"🤖 Prompt for AI Agents
In `@fe/src/components/mission/mission-certification-success-modal.tsx` at line
47, The "다음 미션 찾아보기" button inside the MissionCertificationSuccessModal still
uses bg-main-600 hover:bg-main-700 while the checkmark background was changed to
bg-main-500; update the button's class names in
mission-certification-success-modal.tsx (the button with the label "다음 미션 찾아보기")
to use bg-main-500 and an appropriate hover (e.g., hover:bg-main-600) so the
modal uses a consistent main color scheme.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 작업 내용
🎯 관련 이슈
Closes #
\
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.