Conversation
Closed
1 task
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Walkthrough루틴 인증글 삭제 시 처리 로직을 리팩토링했어. 기존의 하드코딩된 "어제/오늘" 롤백 대신 남은 게시글 기반으로 연속 인증일과 마지막 인증 날짜를 재계산하는 방식으로 변경. 새 헬퍼 함수 2개( Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
🔧 빌드 상태: 성공! ✅Firebase Functions 빌드 및 에뮬레이터 기동이 성공적으로 완료되었습니다! 🎉 ✅ 체크 완료
📊 상세 정보
|
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@be/functions/src/services/communityService.js`:
- Around line 2352-2413: When deleting a routine post, the code currently sets
lastRoutineAuthDate/currentRoutineCommunityId to null if the current community
has no remaining posts, ignoring routine posts in other communities; update the
routineUserUpdate logic in the ROUTINE branch to, when remainingInCommunity is
empty but remainingAll has remaining dates, pick the latest post from
remainingAll (use remainingAll sorted by getDateKey) to set
newCurrentRoutineCommunityId and lastRoutineAuthDate and compute
consecutiveRoutinePosts via countConsecutiveDaysFromLatest on that community's
date set; keep existing decrement logic (shouldDecrementCertificationPosts) and
mirror this same fallback change for the other occurrence around the 2449-2457
region so both code paths recompute based on the latest remaining post across
all communities when the current community is emptied.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 작업 내용
🎯 관련 이슈
Closes #333
Summary by CodeRabbit
버그 수정
✏️ Tip: You can customize this high-level summary in your review settings.