-
Notifications
You must be signed in to change notification settings - Fork 0
feat: implement Android view modules with Kotlin SDK #32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: mm/android-view-stubs
Are you sure you want to change the base?
Conversation
- Integrate BibleText composable in YVPBibleTextView - Integrate VerseOfTheDay composable in YVPVotdView - Integrate BibleWidget composable in YVPBibleWidgetView - Add BibleReaderView placeholder with BibleText
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
Greptile SummaryReplaced placeholder Android views with real Kotlin SDK composables (
Confidence Score: 3/5
Important Files Changed
Sequence DiagramsequenceDiagram
participant RN as React Native
participant View as YVPBibleTextView
participant Props as BibleTextViewProps
participant SDK as Kotlin Platform SDK
participant UI as BibleText Composable
RN->>View: Set props (versionId, bookUSFM, chapter, etc.)
View->>Props: Update MutableState values
Props-->>View: Props updated
RN->>View: Trigger recomposition
View->>View: bibleReference()
View->>View: textOptions()
View->>SDK: Create BibleReference
SDK-->>View: BibleReference instance
View->>UI: BibleText(reference, textOptions, onVerseTap)
UI->>SDK: Fetch Bible text data
SDK-->>UI: Bible text content
UI-->>View: Rendered text
Note over UI,RN: User taps verse
UI->>View: onVerseTap callback
View->>RN: Dispatch onTap event
RN-->>View: Handle verse tap
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
4 files reviewed, 3 comments
android/src/main/java/com/youversion/reactnativesdk/views/YVPBibleTextView.kt
Outdated
Show resolved
Hide resolved
android/src/main/java/com/youversion/reactnativesdk/views/YVPBibleTextView.kt
Outdated
Show resolved
Hide resolved
android/src/main/java/com/youversion/reactnativesdk/views/YVPBibleTextView.kt
Show resolved
Hide resolved
- Fix wocColor default to match iOS (#FF3D4D) - Implement fontFamily prop mapping from string to FontFamily - Document paragraphSpacing limitation (not supported by Kotlin SDK)
Summary
Test plan
cd example && npx expo run:android)