ci: deploy prebuilt static HF Space demo - #210
Merged
Merged
Conversation
ysdede
marked this pull request as ready for review
May 28, 2026 14:41
github-actions Bot
pushed a commit
that referenced
this pull request
May 28, 2026
* ci: deploy prebuilt static HF Space demo * ci: target production HF Space * ci: use root index for static Space a1ee31f
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- In the demo build step you’re using
npm installafter mutatingpackage.json; if you want reproducible CI builds similar to the root you might prefernpm ci(possibly after regenerating a lockfile) or explicitly justify the use ofnpm installhere. - The
huggingface_hubinstallation in the deploy step is currently unpinned; consider pinning it to a specific major/minor version (or using arequirements.txt) to avoid future breaking changes in the CLI impacting deployments.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- In the demo build step you’re using `npm install` after mutating `package.json`; if you want reproducible CI builds similar to the root you might prefer `npm ci` (possibly after regenerating a lockfile) or explicitly justify the use of `npm install` here.
- The `huggingface_hub` installation in the deploy step is currently unpinned; consider pinning it to a specific major/minor version (or using a `requirements.txt`) to avoid future breaking changes in the CLI impacting deployments.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
hf upload --delete '*'.ysdede/parakeet.js-test.Verification
ysdede/parakeet.js-test.RUNNING.app_build_command.Notes
After manual testing, switch default
HF_SPACE_IDfromysdede/parakeet.js-testtoysdede/parakeet.js-demobefore merging/production use.