Skip to content

ci: deploy prebuilt static HF Space demo - #210

Merged
ysdede merged 3 commits into
masterfrom
ci/prebuilt-hf-static-space
May 28, 2026
Merged

ci: deploy prebuilt static HF Space demo#210
ysdede merged 3 commits into
masterfrom
ci/prebuilt-hf-static-space

Conversation

@ysdede

@ysdede ysdede commented May 28, 2026

Copy link
Copy Markdown
Owner

Summary

  • Changes HF Space deploy to build the Vite demo in GitHub Actions.
  • Pushes prebuilt static files to HF with hf upload --delete '*'.
  • Removes HF-side static build config.
  • Defaults manual deploys to private test Space: ysdede/parakeet.js-test.

Verification

  • Local export built successfully.
  • Pushed prebuilt export to ysdede/parakeet.js-test.
  • GitHub Actions workflow dispatch succeeded on this branch.
  • HF test Space runtime is RUNNING.
  • Static URL returns COOP/COEP/CORP headers and README has no app_build_command.

Notes

After manual testing, switch default HF_SPACE_ID from ysdede/parakeet.js-test to ysdede/parakeet.js-demo before merging/production use.

@ysdede
ysdede marked this pull request as ready for review May 28, 2026 14:41
@ysdede
ysdede merged commit a1ee31f into master May 28, 2026
3 checks passed
@ysdede
ysdede deleted the ci/prebuilt-hf-static-space branch May 28, 2026 14:41
github-actions Bot pushed a commit that referenced this pull request May 28, 2026
* ci: deploy prebuilt static HF Space demo

* ci: target production HF Space

* ci: use root index for static Space a1ee31f

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've left some high level feedback:

  • In the demo build step you’re using npm install after mutating package.json; if you want reproducible CI builds similar to the root you might prefer npm ci (possibly after regenerating a lockfile) or explicitly justify the use of npm install here.
  • The huggingface_hub installation in the deploy step is currently unpinned; consider pinning it to a specific major/minor version (or using a requirements.txt) to avoid future breaking changes in the CLI impacting deployments.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- In the demo build step you’re using `npm install` after mutating `package.json`; if you want reproducible CI builds similar to the root you might prefer `npm ci` (possibly after regenerating a lockfile) or explicitly justify the use of `npm install` here.
- The `huggingface_hub` installation in the deploy step is currently unpinned; consider pinning it to a specific major/minor version (or using a `requirements.txt`) to avoid future breaking changes in the CLI impacting deployments.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant